DPL-1093 - As developers we want to find out how to modify the e2e fixtures so we can re-use the factory wrapper that we are creating so we do not have to duplicate requests #1756
Conversation
Created a printers factory.
…o-find-out-how-to-modify-the-e2e-fixtures-so-we-can-re-use-the-factory-wrapper-that-we-are-creating-so-we-do-not-have-to-duplicate-requests
stevieing
changed the title
…o-find-out-how-to-modify-the-e2e-fixtures-so-we-can-re-use-the-factory-wrapper-that-we-are-creating-so-we-do-not-have-to-duplicate-requests
…ility function. Use smrt link factory in pacbioRunCreate store.
Create Pacbio Run factory for use in view. Fix incorrect naming and add some consistency.
…o-find-out-how-to-modify-the-e2e-fixtures-so-we-can-re-use-the-factory-wrapper-that-we-are-creating-so-we-do-not-have-to-duplicate-requests
| store.api.v2.traction.printers.get = vi.fn().mockResolvedValue(printerRequestFactory.response) | ||
| store.api.v2.traction.printers.get = vi | ||
| .fn() | ||
| .mockResolvedValue(printersFactory.responses.fetch) |
There was a problem hiding this comment.
I hope once we move everything to fetch, it will be just be printersFactory.responses.
There was a problem hiding this comment.
Maybe. I like the idea of it being descriptive and it gives us the flexibility of using different response types. I think we might need it if we do location tracking as Labwhere does not use JSON API resource.
| }, | ||
| }, | ||
| } | ||
| } |
|
|
||
| const storeData = dataToObjectById({ ...data }) | ||
|
|
||
| return { ...BaseFactory(data), storeData } |
There was a problem hiding this comment.
I hope keeping store data will simplify unit tests a lot, as we replicate much of it across tests.
There was a problem hiding this comment.
Yes. I decide to add this at this level as each factory will create store data differently. We can see how it progresses ...
There was a problem hiding this comment.
Yes, it is best to keep it here because it varies a lot between stores and probably needs many steps for complicated stores. Maybe after we do all these, we might find some patterns and then we can do further abstraction.
…o-find-out-how-to-modify-the-e2e-fixtures-so-we-can-re-use-the-factory-wrapper-that-we-are-creating-so-we-do-not-have-to-duplicate-requests
|
@seenanair and @dasunpubudumal some stuff was merged into develop this morning so I have had to fix the conflicts. |
stevieing
deleted the
1659-dpl-1093-2---as-developers-we-want-to-find-out-how-to-modify-the-e2e-fixtures-so-we-can-re-use-the-factory-wrapper-that-we-are-creating-so-we-do-not-have-to-duplicate-requests
branch
Closes #
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version